Add support for @direction.
#7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gannan08
force-pushed
the
rdf-direction
branch
from
ec154b2 to
c5f9a45
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7 +/- ##
==========================================
+ Coverage 97.10% 97.12% +0.02%
==========================================
Files 6 6
Lines 138 139 +1
==========================================
+ Hits 134 135 +1
Misses 4 4
Continue to review full report in Codecov by Sentry.
|
dlongley
approved these changes
Nov 22, 2024
dlongley
reviewed
Nov 22, 2024
lib/canonize.js
Outdated
Comment on lines
16
to
17
| const opts = { | ||
| ...options, produceGeneralizedRdf: false, rdfDirection: 'i18n-datatype' |
There was a problem hiding this comment.
Suggested change
| const opts = { | |
| ...options, produceGeneralizedRdf: false, rdfDirection: 'i18n-datatype' | |
| const opts = { | |
| rdfDirection: 'i18n-datatype', ...options, produceGeneralizedRdf: false |
dlongley
reviewed
Nov 22, 2024
lib/canonize.js
Outdated
| const opts = {...options, produceGeneralizedRdf: false}; | ||
| const opts = { | ||
| ...options, produceGeneralizedRdf: false, rdfDirection: 'i18n-datatype' | ||
| }; | ||
| delete opts.format; | ||
| opts.produceGeneralizedRdf = false; |
There was a problem hiding this comment.
Suggested change
| opts.produceGeneralizedRdf = false; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.