Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support node18 #26

Merged
merged 4 commits into from
May 19, 2022
Merged

Support node18 #26

merged 4 commits into from
May 19, 2022

Conversation

dlongley
Copy link
Member

@dlongley dlongley commented May 19, 2022

This is being tested in a number of projects to determine if the changes are sufficient.

@dlongley dlongley requested a review from davidlehn May 19, 2022 19:18
@dlongley
Copy link
Member Author

Looks like we can't get to full node 18 support yet because we can't set cookie headers in requests. The issue of cookies w/ undici fetch is under discussion over here: nodejs/undici#1262

@dlongley dlongley requested a review from davidlehn May 19, 2022 20:50
@codecov-commenter
Copy link

Codecov Report

Merging #26 (6270975) into main (2a47f7b) will decrease coverage by 12.39%.
The diff coverage is 56.33%.

@@             Coverage Diff             @@
##             main      #26       +/-   ##
===========================================
- Coverage   95.27%   82.87%   -12.40%     
===========================================
  Files           2        3        +1     
  Lines         148      216       +68     
===========================================
+ Hits          141      179       +38     
- Misses          7       37       +30     
Impacted Files Coverage Δ
lib/agentCompatibility.js 49.05% <49.05%> (ø)
lib/httpClient.js 93.46% <77.77%> (-1.47%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a47f7b...6270975. Read the comment docs.

@davidlehn davidlehn merged commit 105e70d into main May 19, 2022
@davidlehn davidlehn deleted the support-node18 branch May 19, 2022 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants