2924: Catch SecurityError when accessing localStorage #2974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steffenkleinle
requested review from
ztefanie,
f1sh1918 and
LeandraH
as code owners
steffenkleinle
force-pushed
the
2924-security-error
branch
from
91f8dcf
to
bcf9dda
Compare
|
Code Climate has analyzed commit bcf9dda and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 80.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 74.1%. View more on Code Climate. |
LeandraH
approved these changes
Oct 28, 2024
Comment on lines
+24
to
+27
| // Try to prevent the following error crashing the app: | ||
| // SecurityError: Failed to read the 'localStorage' property from 'Window': Access is denied for this document. | ||
| // See #2924 | ||
| reportError(e) |
There was a problem hiding this comment.
🤔 If we want to leave this comment in permanently, then I think we should rephrase it. If not, I guess we should have some kind of reminder to check in a couple of weeks or months if this issue still occurs. Any thoughts?
Comment on lines
+37
to
+40
| // Try to prevent the following error crashing the app: | ||
| // SecurityError: Failed to read the 'localStorage' property from 'Window': Access is denied for this document. | ||
| // See #2924 | ||
| reportError(e) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Catch SecurityError when accessing localStorage and prevent app from crashing.
Proposed changes
Side effects
None.
Testing
I did not find a way to test this locally (as in: using a development server on localhost) due to me being unable to block localhost from accessing the local storage. Let me know if you can think of another way.
Resolved issues
Fixes: #2924