2520: Show number search results #2976
Conversation
simomps
requested review from
steffenkleinle,
ztefanie,
f1sh1918 and
LeandraH
as code owners
There was a problem hiding this comment.
Thanks for the PR, definitely going in the right direction already and working as expected 🎉
I added a few minor comments, please have a look at styled components.
Implementing this for native is still missing, let me know if you feel comfortable addressing this already, otherwise I can also take over.
One additional thing: We tend to add release notes for issues that are user facing to improve our store presence. Could you please add one for this change? Have a look here: https://github.com/digitalfabrik/integreat-app/blob/main/docs/contributing.md#release-notes
JFYI: The fact that the build is failing is not your fault, to avoid this, simply rebase your branch to main or merge main into your branch. Can also be done at a later point though.
web/src/routes/SearchPage.tsx
Outdated
| @@ -102,6 +102,9 @@ const SearchPage = ({ city, cityCode, languageCode, pathname }: CityRouteProps): | |||
| {query.length > 0 && ( | |||
| <> | |||
| <List> | |||
| <p style={{ margin: '10px 5px', fontSize: 'small' }}> | |||
There was a problem hiding this comment.
🔧 Generally, we use styled-components wherever possible to style our components. Please adjust your PR accordingly. For examples, just search for = styled, e.g. in L20 above.
You can find the docu here: https://styled-components.com/docs/basics#getting-started
web/src/routes/SearchPage.tsx
Outdated
| @@ -102,6 +102,9 @@ const SearchPage = ({ city, cityCode, languageCode, pathname }: CityRouteProps): | |||
| {query.length > 0 && ( | |||
| <> | |||
| <List> | |||
| <p style={{ margin: '10px 5px', fontSize: 'small' }}> | |||
| {`${t('searchResultsCount', { count: results.length })}`} | |||
There was a problem hiding this comment.
🙃 I think this line can be simplified a little,
Short description
Show the amount of search results
Proposed changes
Side effects
None.
Testing
Check css styling
Resolved issues
Fixes: #2520