Refactor "toggle_plural_field.js" #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MizukiTemma
changed the title
JoeyStk
previously requested changes
Jul 6, 2024
MizukiTemma
force-pushed
the
refactor/toggling_document_form
branch
from
f1ddc15 to
f8eda67
Compare
|
@JoeyStk |
sascha11110
force-pushed
the
refactor/toggling_document_form
branch
from
f8eda67 to
080dfd3
Compare
sascha11110
force-pushed
the
refactor/toggling_document_form
branch
from
080dfd3 to
fdf499c
Compare
sascha11110
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
While implementing another issue, I noticed that the file name "toggle_plural_field" does not describe the functions in it anymore well and the function
showDuplicatescan be refectored.Proposed changes
showDuplicatesby creating a helper function and removing duplicatesResolved issues
Fixes: #544