Always delete associated jobs when deleting datasets #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently deleting a dataset is not coupled with deleting jobs with a reference to that dataset. This is done when a dataset is deleted via the webtool, but in other cases
dataset.delete()can be called and potentially leave orphaned jobs.There is no scenario in which a job with a reference to a deleted dataset should exist and keep running, so this PR moves the logic for cleaning up those jobs into the
dataset.delete()method.It's a relatively simple change but worth testing properly, so doing this via a PR rather than a direct commit.