Update dependencies to fix crash on Go 1.17 #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timoreimann
requested review from
gottwald,
varshavaradarajan and
MorrisLaw
timoreimann
force-pushed
the
fix-crash-on-go-1.17
branch
3 times, most recently
from
311c7d9
to
1b00042
Compare
varshavaradarajan
approved these changes
Sep 19, 2021
added 2 commits
September 19, 2021 16:46
When running clusterlint on Go 1.17, it panics right on startup. The issue is our usage of github.com/mattn/go-isatty (consumed by github.com/fatih/color) which had a bug until [1]. Updating to the latest v0.0.14 release fixes the issue. Also bump the minimum (library) dependency to 1.16 in go.mod since that is the oldest, officially supported Go version. Bumping to 1.17 actually enables us to fix the issue by simply updating to the latest github.com/fatih/color, as opposed to adding an indirect import of github.com/mattn/go-isatty which this change does right now (which I suppose works due to Go 1.17 module management improvements); however, that'd come at the price of breaking compatibility with 1.16 users which is non-ideal. Regardless, update github.com/fatih/color as well while we're here. Also bump the version of the Go image used for testing. [1] mattn/go-isatty#66
timoreimann
force-pushed
the
fix-crash-on-go-1.17
branch
from
1b00042
to
92d914f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running clusterlint on Go 1.17, it panics right on startup. The issue is our usage of github.com/mattn/go-isatty (consumed by
github.com/fatih/color) which had a bug until mattn/go-isatty#66. Updating to the latest v0.0.14 release fixes the issue.
Also bump the minimum (library) dependency to 1.16 in go.mod since that is the oldest, officially supported Go version. Bumping to 1.17 actually enables us to fix the issue by simply updating to the latest github.com/fatih/color, as opposed to adding an indirect import of github.com/mattn/go-isatty which this change does right now (which I suppose works due to Go 1.17 module management improvements); however, that'd come at the price of breaking compatibility with 1.16 users which is non-ideal.
Regardless, update github.com/fatih/color as well while we're here.
Also bump the version of the Go image used for testing and add a quick smoke-test that invokes the built binary.
Fixes #125