Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CDN: Add support for configuring custom subdomains in Spaces CDN. #207

Merged
merged 2 commits into from
Mar 4, 2019
Merged

CDN: Add support for configuring custom subdomains in Spaces CDN. #207

merged 2 commits into from
Mar 4, 2019

Conversation

xornivore
Copy link
Contributor

@sunny-b
Copy link
Contributor

sunny-b commented Mar 1, 2019

LGTM

@sunny-b
Copy link
Contributor

sunny-b commented Mar 1, 2019

Actually just remembered that you will need to update the library version here:

https://github.com/digitalocean/godo/blob/master/godo.go#L20

hilary
hilary approved these changes Mar 1, 2019
View reviewed changes
Copy link
Contributor

@hilary hilary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@xornivore xornivore merged commit 2e4625e into digitalocean:master Mar 4, 2019
@eddiezane eddiezane mentioned this pull request Apr 10, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hilary hilary hilary approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xornivore @sunny-b @hilary