Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tags for storage volumes #210

Merged
merged 1 commit into from
Mar 13, 2019
Merged

Add tags for storage volumes #210

merged 1 commit into from
Mar 13, 2019

Conversation

jcodybaker
Copy link
Contributor

  • Add tags field for storage volumes.
  • Add tags field to tests.

nanzhong
nanzhong approved these changes Mar 8, 2019
View reviewed changes
Copy link
Contributor

@nanzhong nanzhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

hilary
hilary approved these changes Mar 12, 2019
View reviewed changes
Copy link
Contributor

@hilary hilary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jcodybaker jcodybaker merged commit 0416126 into master Mar 13, 2019
@jcodybaker jcodybaker deleted the storage-vol-tags branch March 13, 2019 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hilary hilary hilary approved these changes

@nanzhong nanzhong nanzhong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jcodybaker @nanzhong @hilary