Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefix import does not include VLAN #1104

Closed
royvegard opened this issue Apr 25, 2017 · 1 comment
Closed

Prefix import does not include VLAN #1104

royvegard opened this issue Apr 25, 2017 · 1 comment
Labels
type: bug A confirmed report of unexpected behavior in the application

Comments

@royvegard
Copy link

Issue type: Bug report

Python version: 2.7.12
NetBox version: 1.9.7-dev 861c8b2

Importing a prefix with a valid VLAN does not include the VLAN.

Steps to reproduce

  1. Create a VLAN with and ID of 100.
  2. Enter the following into the Prefix import form and submit:
    192.0.2.0/24,,,,,100,Active,,False,

The prefix will be imported but it will not include the VLAN.

I believe this was introduced in d3b16ba. Line 239 is always executed - setting self.instance.vlan = vlan which sets it to None. I'm guessing that it should only be executed if exeption VLAN.MultipleObjectsReturned happens.

@jeremystretch jeremystretch added the type: bug A confirmed report of unexpected behavior in the application label Apr 26, 2017
@jeremystretch
Copy link
Member

Thanks!

lampwins pushed a commit to lampwins/netbox that referenced this issue Oct 13, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Development

No branches or pull requests

2 participants