Make sure to display old deprecated instance sizes (#939)

* Make sure to display old deprecated instance sizes

* fix: reference to old size slugs

* add example for instance_size_slug

* refactor: add old instance sizes inline instead of separate enum type

Co-authored-by: Andrew Starr-Bochicchio <andrewsomething@users.noreply.github.com>

---------

Co-authored-by: Anna Lushnikova <loosla@users.noreply.github.com>
Co-authored-by: Anna Lushnikova <anna.loosla@gmail.com>
Co-authored-by: Andrew Starr-Bochicchio <andrewsomething@users.noreply.github.com>

specification/resources/apps/models/app_component_instance_base.yml

@@ -5,31 +5,52 @@ properties:
     type: integer
     format: int64
     minimum: 1
-    description: 'The amount of instances that this component should be scaled to. Default: 1. Must not be set if autoscaling is used.'
+    description: "The amount of instances that this component should be scaled to. Default: 1. Must not be set if autoscaling is used."
     default: 1
     example: 2
 
   instance_size_slug:
-    description: 'The instance size to use for this component. Default: `apps-s-1vcpu-0.5gb`'
-    type: string
-    enum:
-    - apps-s-1vcpu-0.5gb
-    - apps-s-1vcpu-1gb-fixed
-    - apps-s-1vcpu-1gb
-    - apps-s-1vcpu-2gb
-    - apps-s-2vcpu-4gb
-    - apps-d-1vcpu-0.5gb
-    - apps-d-1vcpu-1gb
-    - apps-d-1vcpu-2gb
-    - apps-d-1vcpu-4gb
-    - apps-d-2vcpu-4gb
-    - apps-d-2vcpu-8gb
-    - apps-d-4vcpu-8gb
-    - apps-d-4vcpu-16gb
-    - apps-d-8vcpu-32gb
-    default: apps-s-1vcpu-0.5gb
+    description: "The instance size to use for this component. Default: `apps-s-1vcpu-0.5gb`"
+    oneOf:
+      - title: "Size slug"
+        type: string
+        enum:
+          - apps-s-1vcpu-0.5gb
+          - apps-s-1vcpu-1gb-fixed
+          - apps-s-1vcpu-1gb
+          - apps-s-1vcpu-2gb
+          - apps-s-2vcpu-4gb
+          - apps-d-1vcpu-0.5gb
+          - apps-d-1vcpu-1gb
+          - apps-d-1vcpu-2gb
+          - apps-d-1vcpu-4gb
+          - apps-d-2vcpu-4gb
+          - apps-d-2vcpu-8gb
+          - apps-d-4vcpu-8gb
+          - apps-d-4vcpu-16gb
+          - apps-d-8vcpu-32gb
+        default: apps-s-1vcpu-0.5gb
+        example: apps-s-1vcpu-0.5gb
+      - title: "Deprecated"
+        description: | 
+          Deprecated size slugs for legacy plans. We strongly encourage customers
+          to use the new plans when creating or upgrading apps.
+        type: string
+        enum:
+          - basic-xxs
+          - basic-xs
+          - basic-s
+          - basic-m
+          - professional-xs
+          - professional-s
+          - professional-m
+          - professional-1l
+          - professional-l
+          - professional-xl
+        example: basic-xxs
+        deprecated: true
     example: apps-s-1vcpu-0.5gb
-  
+
   autoscaling:
     description: Configuration for automatically scaling this component based on metrics.
     type: object
@@ -61,4 +82,4 @@ properties:
                 minimum: 1
                 maximum: 100
                 default: 80
-                example: 75
+                example: 75