Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add update an ssh key endpoint #14

Merged
merged 4 commits into from
Jul 22, 2020
Merged

add update an ssh key endpoint #14

merged 4 commits into from
Jul 22, 2020

Conversation

hilary
Copy link
Contributor

@hilary hilary commented Jul 21, 2020

The branch for this PR branches off of #12, so merge that one first. 😄

Although our current docs lists this endpoint as a PUT, it works with PATCH as well. As it takes the name attribute only, it is a PATCH endpoint, not a PUT endpoint. Since aliasing the two is a violation of OpenAPI (and using PUT as an alias for PATCH is a violation of HTTP), the endpoint is listed as PATCH.

scotchneat
scotchneat approved these changes Jul 22, 2020
View reviewed changes
Copy link
Contributor

@scotchneat scotchneat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@scotchneat scotchneat merged commit 172858b into main Jul 22, 2020
@hilary hilary deleted the APICLI-381-update branch July 22, 2020 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scotchneat scotchneat scotchneat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hilary @scotchneat