organize contents by resource #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scotchneat
reviewed
Jul 1, 2020
There was a problem hiding this comment.
I added comments regarding the decorated and wrapped models and a suggestion to reduce the number of refs in those cases. It's not a deal breaker as the current PR looks good, but I thought I'd bring it up for discussion now before we have a lot more resources.
experimenting a bit with putting models and responses under their own directory with ssh_keys, as "list_all_keys" was getting really long even without 4xx responses.
andrewsomething
approved these changes
Jul 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
experimenting a bit with putting models and responses under their own directory
with ssh_keys, as "list_all_keys" was getting really long even without 4xx responses.
Includes necessary changes to spectral rules.