add more ssh key endpoints #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hilary
changed the title
scotchneat
reviewed
Jul 13, 2020
Comment on lines
+6
to
+8
| oneOf: | ||
| - $ref: '../attributes/ssh_key_id.yml' | ||
| - $ref: '../attributes/ssh_key_fingerprint.yml' |
There was a problem hiding this comment.
I'm testing with the mocked proxy and it looks like the prism proxy is having an issue matching integer ids here.
I'll have to keep testing to see if I could identify what exactly is happening before I decide if this is an issue or not.
scotchneat
approved these changes
Jul 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge PR #4 before merging this PR, as it is based on #4.
adds:
GET /v2/account/keys/{ssh_key_identifier}DELETE /v2/account/keys/{ssh_key_identifier}I'm impressed by how robust the
OpenAPI Previewextension for VS Code is.