Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update apps_update.yml #953

Merged
merged 4 commits into from
Dec 5, 2024
Merged

Update apps_update.yml #953

merged 4 commits into from
Dec 5, 2024

Conversation

dbrian57
Copy link
Contributor

@dbrian57 dbrian57 commented Dec 5, 2024

Updates App update cURL example to be complete.

Updates App update cURL example to be complete
@dbrian57 dbrian57 added the documentation Improvements or additions to documentation label Dec 5, 2024
Copy link
Member

@andrewsomething andrewsomething left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Let a comment inline that should resolve the CI failure. Beyond that, I wonder if we could use a more minimal example? This is pretty hard to read.

feedback via ASB

Co-authored-by: Andrew Starr-Bochicchio <andrewsomething@users.noreply.github.com>
@dbrian57
Copy link
Contributor Author

dbrian57 commented Dec 5, 2024

@andrewsomething sure thing! I'll work something up.

More minimal app spec
@dbrian57
Copy link
Contributor Author

dbrian57 commented Dec 5, 2024

@andrewsomething How do you feel about this? Should I uncompress it? I compressed it for easier copying, but maybe that's not the move here

Copy link
Member

@andrewsomething andrewsomething left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Works for me. Thanks Dan!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants