Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update deps #53

Merged
merged 5 commits into from
Apr 27, 2021
Merged

Conversation

achingbrain
Copy link
Collaborator

Updates to new buffer version among other things to reduce the amount
of bloat in browser bundles.

@rvagg
Copy link

rvagg commented Apr 26, 2021

CI failures for Windows are a weird timeout - the tests are passing just fine but exit doesn't seem to be registered.

The browser failures look identical to what I hit @ ipfs/js-ipfs-unixfs#116 (comment), maybe try switching from bionic to focal and 🤞.

@rvagg
Copy link

rvagg commented Apr 26, 2021

nope that didn't work .. I was having trouble reproducing the case locally when trying to narrow down something to report to esbuild but couldn't do it, there's something really quirky with the conditions in which it removes typeof require === "function" in dirty-chai, but I can't find it in their code (yet).

@achingbrain
Copy link
Collaborator Author

Hmm, it's definitely esbuild related - something that has changed between 0.11.5 and 0.11.15.

aegir is pinned to 0.11.5 but playwright-test has ^0.11.5 which resolves to 0.11.15 right now.

If I run the browser tests on Mac OS X I get the failure, but if I manually dedupe esbuild so only 0.11.5 is present in node_modules everything passes.

cc @hugomrdias

@achingbrain
Copy link
Collaborator Author

v0.11.10 seems to be the last version that works properly, the error appears with esbuild@0.11.11.

@achingbrain
Copy link
Collaborator Author

I've opened an issue here: evanw/esbuild#1202

Updates to new buffer version among other things to reduce the amount
of bloat in browser bundles.
@achingbrain achingbrain merged commit c31a142 into dignifiedquire:master Apr 27, 2021
@achingbrain achingbrain deleted the chore/update-deps branch April 27, 2021 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants