Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added cat #2

Merged
merged 1 commit into from
Dec 8, 2015
Merged

Added cat #2

merged 1 commit into from
Dec 8, 2015

Conversation

RichardLitt
Copy link
Collaborator

Had some issues with attributes and body, but I think the use of headers clears it up

Retrieves the object named by <ipfs-or-ipns-path> and outputs the data it contains.

+ Parameters
+ arg (string, required) - The path to the IPFS object(s) to be outputted

+ Response 200 (text/plain)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about the response time, as it depends on the file.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did I specify the response time?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

..... response mime type...........

@dignifiedquire
Copy link
Owner

Would be nice to have an example response here for e.g. a textfile

@dignifiedquire
Copy link
Owner

Merge conflicts

@RichardLitt RichardLitt force-pushed the feature/cat branch 2 times, most recently from 6d7c057 to b1591f1 Compare December 8, 2015 20:48
+ Body

```
$ curl -i http://localhost:5001/api/v0/cat?arg=QmeomffUNfmQy76CQGy9NdmqEnnHU9soCexBnGU3ezPHVH
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curl in the body?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. Not sure how to show the file we're using as the test? This is wrong; looking for a solution now.

@RichardLitt RichardLitt force-pushed the feature/cat branch 2 times, most recently from eed87c3 to d26f393 Compare December 8, 2015 21:03
@RichardLitt
Copy link
Collaborator Author

Removed example. Ready to merge. Opening issue to talk about it.

@@ -689,10 +689,17 @@ Import a tar file into ipfs

+ Response 200 (text/plain)

## cat [GET /tar/cat]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove /tar/cat?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question. Rebase mess up. Removed cat in #1 by accident; added it back in properly now. Thanks for the catch. Clearly my bad.

dignifiedquire added a commit that referenced this pull request Dec 8, 2015
@dignifiedquire dignifiedquire merged commit 7b91ccf into master Dec 8, 2015
@dignifiedquire dignifiedquire deleted the feature/cat branch December 8, 2015 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants