-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added cat #2
Added cat #2
Conversation
Retrieves the object named by <ipfs-or-ipns-path> and outputs the data it contains. | ||
|
||
+ Parameters | ||
+ arg (string, required) - The path to the IPFS object(s) to be outputted | ||
|
||
+ Response 200 (text/plain) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about the response time, as it depends on the file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did I specify the response time?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
..... response mime type...........
Would be nice to have an example response here for e.g. a textfile |
Merge conflicts |
6d7c057
to
b1591f1
Compare
+ Body | ||
|
||
``` | ||
$ curl -i http://localhost:5001/api/v0/cat?arg=QmeomffUNfmQy76CQGy9NdmqEnnHU9soCexBnGU3ezPHVH |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
curl in the body?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. Not sure how to show the file we're using as the test? This is wrong; looking for a solution now.
eed87c3
to
d26f393
Compare
Removed example. Ready to merge. Opening issue to talk about it. |
d26f393
to
f8bbee2
Compare
@@ -689,10 +689,17 @@ Import a tar file into ipfs | |||
|
|||
+ Response 200 (text/plain) | |||
|
|||
## cat [GET /tar/cat] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you remove /tar/cat
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question. Rebase mess up. Removed cat in #1 by accident; added it back in properly now. Thanks for the catch. Clearly my bad.
f8bbee2
to
a3bf473
Compare
Had some issues with attributes and body, but I think the use of headers clears it up