-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding eslint #32
adding eslint #32
Conversation
I'm curious, why
|
@gregorysl It was caught by the linter and easy to change, so I made the change. JavaScript files containing jsx should contain that file extension. Feel free to revert if you'd like. More on this here: airbnb/javascript#985 |
Thank you so much for the very thoughtful and lengthy PR. I just looked through the lint and it looks very clean. Great work 🎉 💯 Looking more into it, I think it still might be better to keep the files named as Other than that, just fix the merge conflicts and I will merge this in 😄 |
src/features/Issues/Issues.jsx
Outdated
const Card = ({ | ||
title, body, labels, issueUrl, owner, repo, number, | ||
}) => ( | ||
======= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some merge conflicts remaining
Resolved the conflicts, looks good to go from my end! Comment away if there's something I missed. Other than that, I completely support the decision to keep using .js files and think there's definitely a good argument for doing so. I enjoyed contributing here and would be interested in tackling more issues in the future! |
Encountered a second error after fixing this, both should be fixed now |
Merged it in, thanks again so much for your help! |
I added eslint to the project. Here's a couple notes:
I'd recommend moving forward that whoever's project this is make decisions about the linting rules, then remove/change the rules set in .eslintrc.json and fix the files so the code complies with the rules decided upon.
Having said that, thank you for letting me contribute. If you have any questions, comments, please let me know or comment directly in the PR and I can make changes before merging.