Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exposes GraphQLESTreeNode type #2418

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

comatory
Copy link
Contributor

Description

We use some custom eslint plugins that build on top of @graphql-eslint/eslint-plugin and it cannot be imported directly from the package if Typescript's config is set to use moduleResolution: NodeNext or any other resolution type. This means explicitly making it public is the easiest way to use it.

Fixes #2399

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • This change requires a documentation update

Screenshots/Sandbox (if appropriate/relevant):

N/A

How Has This Been Tested?

No, it is just exposing new type.

Test Environment:

N/A

Checklist:

  • I have followed the
    CONTRIBUTING doc and the
    style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests and linter rules pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Further comments

Unfortunately, I'm not able to make tests pass locally. I get this failure:

@graphql-eslint/eslint-plugin:test:  FAIL  __tests__/examples.spec.ts > Examples > should work in monorepo
@graphql-eslint/eslint-plugin:test: Error:
@graphql-eslint/eslint-plugin:test: Oops! Something went wrong! :(
@graphql-eslint/eslint-plugin:test:
@graphql-eslint/eslint-plugin:test: ESLint: 8.57.0
@graphql-eslint/eslint-plugin:test:
@graphql-eslint/eslint-plugin:test: file:///Users/ondrej.synacek/Projects/graphql-eslint/packages/plugin/dist/esm/types.js:2
@graphql-eslint/eslint-plugin:test: import { GraphQLESTreeNode as GraphQLESTreeNode2 } from "./estree-converter/types.js";
@graphql-eslint/eslint-plugin:test:          ^^^^^^^^^^^^^^^^^
@graphql-eslint/eslint-plugin:test: SyntaxError: The requested module './estree-converter/types.js' does not provide an export named 'GraphQLESTreeNode'
es.js' does not provide an export named 'GraphQLESTreeNode'

Can I ask for assistance on this one? 🙇 Thanks

Copy link

changeset-bot bot commented Jun 25, 2024

🦋 Changeset detected

Latest commit: edb5115

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@graphql-eslint/eslint-plugin Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dimaMachina dimaMachina merged commit c2d5386 into dimaMachina:master Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

node related types
2 participants