Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: original file should not be considered as file block #394

Merged
merged 2 commits into from
Apr 22, 2021
Merged

fix: original file should not be considered as file block #394

merged 2 commits into from
Apr 22, 2021

Conversation

JounQin
Copy link
Contributor

@JounQin JounQin commented Apr 22, 2021

Related #88

ESLint supports text directly, no need to use the hacky way. See https://github.com/eslint/eslint/blob/master/lib/linter/linter.js#L1298

Besides, I've fixed related eslint-plugin-prettier's issue at prettier/eslint-plugin-prettier#401

@changeset-bot
Copy link

changeset-bot bot commented Apr 22, 2021

🦋 Changeset detected

Latest commit: 6003770

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@graphql-eslint/eslint-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dotansimha
Copy link
Collaborator

Thank you @JounQin ! Can you please add a changeset file? (Run yarn changeset and it will guide you).

@JounQin
Copy link
Contributor Author

JounQin commented Apr 22, 2021

@dotansimha Done!

@dotansimha dotansimha merged commit 1257d51 into dimaMachina:master Apr 22, 2021
@JounQin JounQin deleted the fix/file_block branch April 22, 2021 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants