support getting count without querying #28895
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When exporting large datasets having the progress output is very helpful. For the ICDS data export I added progress output for the SQL exporter https://github.com/dimagi/commcare-icds/pull/157/files#diff-2299e47508434b48a9b377144efb0fe3e4f283b35ce6539b3b641a968b5b2251R150
This change moves the counting to the builders and filters so that the SQL count query can be skipped if the filter already knows the total count (e.g. when filtering by ID or username).
Safety Assurance
Rollback instructions