Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support getting count without querying #28895

Merged
merged 1 commit into from
Dec 15, 2020
Merged

support getting count without querying #28895

merged 1 commit into from
Dec 15, 2020

Conversation

snopoke
Copy link
Contributor

@snopoke snopoke commented Dec 15, 2020

Summary

When exporting large datasets having the progress output is very helpful. For the ICDS data export I added progress output for the SQL exporter https://github.com/dimagi/commcare-icds/pull/157/files#diff-2299e47508434b48a9b377144efb0fe3e4f283b35ce6539b3b641a968b5b2251R150

This change moves the counting to the builders and filters so that the SQL count query can be skipped if the filter already knows the total count (e.g. when filtering by ID or username).

Safety Assurance

  • Risk label is set correctly
  • The set of people pinged as reviewers is appropriate for the level of risk of the change
  • If QA is part of the safety story, the "Awaiting QA" label is used
  • I am certain that this PR will not introduce a regression for the reasons below

Rollback instructions

  • This PR can be reverted after deploy with no further considerations

@snopoke snopoke added the product/invisible Change has no end-user visible impact label Dec 15, 2020
@snopoke snopoke merged commit 6a288c2 into master Dec 15, 2020
@snopoke snopoke deleted the sk/export-count branch December 15, 2020 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product/invisible Change has no end-user visible impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants