Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add lodash to require_config so that WIPs can start importing during migration #29747

Closed
wants to merge 1 commit into from

Conversation

biyeun
Copy link
Member

@biyeun biyeun commented May 18, 2021

Summary

We are officially beginning the migration from underscore to lodash. The recent CVE for underscore prompted us to fast-track the upgrade progress for underscore, which we realized breaks lots of things including require.js imports.

This PR adds 'lodash' to the short-hand paths so that it can be available for devs to use right now for any WIPs not yet merged into master.

By the way, these breaking changes for minor versions are not the first time this has happened. If you read this thread, it's very clear the maintainers do not care about breaking changes or your "problematic" legacy applications. See sentimental versioning for some other similarly-versioned libraries (and a good laugh).

Safety Assurance

  • Risk label is set correctly
  • All migrations are backwards compatible and won't block deploy
  • The set of people pinged as reviewers is appropriate for the level of risk of the change
  • If QA is part of the safety story, the "Awaiting QA" label is used
  • I have confidence that this PR will not introduce a regression for the reasons below

Automated test coverage

QA Plan

We will do a QA round on the actual migration.

Safety story

This just makes lodash easily available. Does not change any active code.

Rollback instructions

  • This PR can be reverted after deploy with no further considerations

@dimagimon dimagimon added the Risk: High Change affects files that have been flagged as high risk. label May 18, 2021
@biyeun biyeun added dependencies/javascript Change in javascript dependency. product/invisible Change has no end-user visible impact and removed Risk: High Change affects files that have been flagged as high risk. labels May 18, 2021
@biyeun
Copy link
Member Author

biyeun commented May 19, 2021

Note: holding off until the pressure of SSO development reduces and I have capacity to come up with a full plan (see conversation in slack)

@biyeun biyeun closed this Jul 24, 2023
@biyeun biyeun deleted the bmb/begin-migration-to-lodash branch July 24, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies/javascript Change in javascript dependency. product/invisible Change has no end-user visible impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants