[B5 Migration] Add support for ES6 Modules and split core javascript into bootstrap5 and bootstrap3 versions (take 2) #33083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of our javascript libraries separately
…ld doesn't break on hqwebapp/js/500
…on the bootstrap3 or 5 version and make sure use_bootstrap5 is in template context
dimagimon
added
dependencies
millerdev
reviewed
Jun 8, 2023
There was a problem hiding this comment.
This is a "revert" of #32907
Did you mean "redo" instead of "revert"? The first commit in that other PR looks the same as the first commit in this one, not like a reversal.
Can you point out what changed between this PR and the previous one since it's quite large?
|
It's more of a redo because a change was committed to HQ to |
|
@millerdev the last two commits are the only differences |
millerdev
approved these changes
Jun 8, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a "revert" of #32907
Note that these changes have properly gone through QA on staging and signed off.
This commcare-cloud PR was key in resolving the symptoms of the issue, ensuring that no live bootstrap 3 pages were affected. I will revisit the more longterm fix for bootstrap 5 pages after I've taken a pass at writing the migration helper scripts.
Related ticket: https://dimagi-dev.atlassian.net/browse/SAAS-14253
Safety Assurance
Safety story
QA'd successfully
Automated test coverage
Yes
QA Plan
Yes
Rollback instructions
Labels & Review