USH-4329: Make anchored submit button sticky #34490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimagimon
added
the
Risk: Medium
MartinRiese
requested review from
orangejenny,
biyeun,
esoergel,
AddisonDunn,
stephherbers,
Robert-Costello,
Jtang-1 and
nospame
as code owners
Jtang-1
reviewed
Apr 24, 2024
corehq/apps/cloudcare/templates/cloudcare/partials/form_entry_templates.html
Outdated
Show resolved
Hide resolved
Jtang-1
approved these changes
Apr 24, 2024
nospame
approved these changes
Apr 24, 2024
|
Seems like this needs |
* update bootstrap diff
MartinRiese
force-pushed
the
riese/style-anchored-submit
branch
from
115bd78 to
354f8a8
Compare
MartinRiese
commented
Apr 24, 2024
corehq/apps/hqwebapp/static/cloudcare/scss/formplayer-webapp/form.scss
Outdated
Show resolved
Hide resolved
… into jls/b5-registry+riese/style-anchored-submit
Jtang-1
approved these changes
Apr 30, 2024
|
confirmed B5 changes look good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Product Description
Making submit button sticky instead of fixed to the bottom of the page.
2024-04-23_09-17-22.mp4
Technical Summary
https://dimagi.atlassian.net/browse/USH-4329
Feature Flag
USH: Keep submit button anchored at the bottom of screen for forms in Web Apps
Safety Assurance
Safety story
Automated test coverage
QA Plan
Rollback instructions
Labels & Review