Added knockout_bindings as a dependency of entries.js #34523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orangejenny
added
the
product/all-users-all-environments
orangejenny
requested review from
Robert-Costello,
Jtang-1 and
nospame
as code owners
dimagimon
added
the
Risk: Medium
esoergel
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Product Description
https://dimagi.atlassian.net/browse/SUPPORT-19569
Fixes a bug where "Clear" buttons were showing for checkbox questions. They should only show for questions using radio buttons.
Technical Summary
Introduced in #34271 when we started using expicit dependencies.
The
fadeVisiblebinding that controls the "Clear" button for multiselect questions (see here) is defined inknockout_bindings.ko.js, so that needs to be added as a dependency.Safety Assurance
Safety story
Local testing should be sufficient for this. Tiny, very low-risk change.
Automated test coverage
not really
QA Plan
no
Rollback instructions
Labels & Review