Resize app preview properly for tablet view on page load #34580
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Product Description
https://dimagi.atlassian.net/browse/SAAS-15524
Technical Summary
Probably introduced by the requirejs migration. As explained in ticket:
I don't like that formplayer js now knows about data that's conceptually part of app manager, but I do like that this is simple. The best alternative is probably to have app preview to signal to app manager when it's finished loading, but the app manager / app preview relationship is currently structured so that app manager sends instructions to app preview, not the other way around.
Safety Assurance
Safety story
Risk is pretty minor here, the change is quite targeted. Tested locally.
Automated test coverage
No
QA Plan
Not requesting QA
Rollback instructions
Labels & Review