Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Case and User Ownership (Script) #34588
base: master
Are you sure you want to change the base?
Change Case and User Ownership (Script) #34588
Changes from all commits
3cc7f6f
006a266
ff5cdae
b47f557
3d045ad
2b80d2e
c35c65d
975cd7f
bf3b264
d777a43
4a9d929
51734c4
a6d54c5
d436a14
3aaa66f
25e153b
c87c4b8
192b6ee
ce348c4
0f092e1
1760f47
c10d783
01c4f7c
559dfad
a000ce2
5888d2f
c817a30
e4e7b5a
4cb9da3
949d47c
8f050f7
7875743
aba0953
3e6ce37
f6a371a
fabe95a
9288792
e1e7c63
136cae3
cae7288
26498e9
81f1849
16bcbb8
886d3d2
5645fc7
9d053f8
768994c
bc7708a
9625ab1
ceb0992
5bf510b
80dc9f7
6c16dee
26e3e0d
e11aa9f
ff44777
c4c23bc
80fc2c7
130b843
3154c6f
c7e2cdb
cb455b5
0e160f1
9fc9cc1
ed4e5e8
2098d59
1ca177a
d799f67
2056184
e7ab359
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check failure on line 148 in custom/benin/management/commands/migrate_users_and_their_cases_to_new_rc_level.py
GitHub Actions / Flake8
custom/benin/management/commands/migrate_users_and_their_cases_to_new_rc_level.py#L148
Check failure on line 152 in custom/benin/management/commands/migrate_users_and_their_cases_to_new_rc_level.py
GitHub Actions / Flake8
custom/benin/management/commands/migrate_users_and_their_cases_to_new_rc_level.py#L152
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh this was needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, based on the discussion with Adam, it was decided to have only the
rc
location for the mobile worker.(Side note: It also helps issues (location ambiguity) with Case Sharing to have only 1 location that own cases)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay, good to not do this if
existing_location
is same asnew_location
, Not sure if that is possible or not.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new_location
will always be different fromexisting_location
for this script because it is child location of the existing location.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
celery is great approach. Just one thing to note is that once things are in celery, you won't have any visibility/control on the updates as you lose the logging and once the tasks are queued up you don't know when they would get picked up.
Just good to consider that before you finalize the approach.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noted. That is a valid concern.
I have added a new logger (file) for the script however I am not sure if it work when tasks are run across multiple celery machines.