Replace nose with pytest

.github/CODEOWNERS

@@ -23,8 +23,7 @@
 /corehq/sql_db/ @snopoke @calellowitz
 /corehq/sql_proxy_accessors/ @snopoke
 /corehq/sql_proxy_standby_accessors/ @snopoke
-/corehq/tests/nose.py @millerdev
-/corehq/tests/noseplugins/ @millerdev
+/corehq/tests/ @millerdev
 /corehq/util/couch.py @esoergel
 /corehq/util/couch_helpers.py @millerdev
 /corehq/util/datadog/lockmeter.py @millerdev

.github/workflows/tests.yml

@@ -19,9 +19,9 @@ jobs:
       fail-fast: false
       matrix:
         include:
-        - {TEST: python, NOSE_DIVIDED_WE_RUN: '05'}
-        - {TEST: python, NOSE_DIVIDED_WE_RUN: '6a'}
-        - {TEST: python, NOSE_DIVIDED_WE_RUN: 'bf'}
+        - {TEST: python, DIVIDED_WE_RUN: '05'}
+        - {TEST: python, DIVIDED_WE_RUN: '6a'}
+        - {TEST: python, DIVIDED_WE_RUN: 'bf'}
         - {TEST: python-sharded-and-javascript}
     env:
       DATADOG_API_KEY: ${{ secrets.DATADOG_API_KEY }}
@@ -46,11 +46,11 @@ jobs:
     - name: Run tests
       env:
         TEST: ${{ matrix.TEST }}
-        NOSE_DIVIDED_WE_RUN: ${{ matrix.NOSE_DIVIDED_WE_RUN }}
+        DIVIDED_WE_RUN: ${{ matrix.DIVIDED_WE_RUN }}
         JS_SETUP: yes
         KAFKA_HOSTNAME: kafka
         STRIPE_PRIVATE_KEY: ${{ secrets.STRIPE_PRIVATE_KEY }}
-      run: scripts/docker test --noinput --stop -v --divided-we-run=${{ matrix.NOSE_DIVIDED_WE_RUN }} --divide-depth=1 --with-timing --with-flaky --threshold=10 --max-test-time=29
+      run: scripts/docker test --noinput --stop -v --divided-we-run=${{ matrix.DIVIDED_WE_RUN }} --with-timing --with-flaky --threshold=10 --max-test-time=29
     - name: "Codecov upload"
       env:
         TOKEN: ${{ secrets.CODECOV_TOKEN }}

.pytest.ini

@@ -0,0 +1,27 @@
+[pytest]
+minversion = 8.1
+
+addopts =
+    --strict-markers
+    -pcorehq.tests.pytest_hooks
+    # HQ has its own (incompatible) warnings system
+    -pno:warnings
+markers =
+    es_test: marker for elasticsearch tests
+    sharded: tests to be run against shard databases
+    slow: marks tests as slow (deselect with -m 'not slow')
+
+empty_parameter_set_mark = fail_at_collect
+xfail_strict = true
+
+norecursedirs =
+    docker
+    node_modules
+    staticfiles
+
+pythonpath =
+    .
+    corehq/ex-submodules
+
+required_plugins = pytest-django
+DJANGO_SETTINGS_MODULE = testsettings

corehq/apps/es/tests/utils.py

@@ -98,7 +98,7 @@ def checkQuery(self, query, expected_json, is_raw_query=False, validate_query=Tr
 @nottest
 def es_test(test=None, requires=None, setup_class=False):
     """Decorator for Elasticsearch tests.
-    The decorator sets the ``es_test`` nose attribute and optionally performs
+    The decorator sets the ``es_test`` pytest marker and optionally performs
     index setup/cleanup before and after the test(s).
 
     :param test: A test class, method, or function -- only used via the

corehq/apps/es/transient_util.py

@@ -88,7 +88,6 @@ def populate_doc_adapter_map():
         from pillowtop.tests.utils import TEST_ES_TYPE, TEST_ES_MAPPING, TEST_ES_INDEX
         add_dynamic_adapter("PillowTop", TEST_ES_INDEX, TEST_ES_TYPE, TEST_ES_MAPPING)
 
-        import corehq.tests.pytest_compat  # noqa: F401 - to be removed after switch to pytest
         from corehq.apps.es.tests.utils import TEST_ES_INFO, TEST_ES_MAPPING
         add_dynamic_adapter("UtilES", TEST_ES_INFO.alias, TEST_ES_INFO.type,
                         TEST_ES_MAPPING)

corehq/tests/nosecompat.py

@@ -0,0 +1,13 @@
+import sys
+
+from .tools import nottest as nottest_tool
+
+
+def create_nose_virtual_package():
+    sys.modules['nose.tools'] = VirtualNose.tools
+
+
+class VirtualNose:
+    """Legacy namespace for tests written before pytest"""
+    class tools:
+        nottest = nottest_tool

corehq/tests/noseplugins/__init__.py

@@ -1 +0,0 @@
-import corehq.tests.pytest_compat  # noqa: F401