Allow case_search_display and case_search_hint values to be translated in Transifex #34794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minhaminha
added
the
product/feature-flag
Jtang-1
reviewed
Jun 19, 2024
…display update also + small nit changes
Jtang-1
reviewed
Jun 21, 2024
…traneous case search properties
Jtang-1
approved these changes
Jun 24, 2024
| self.msgs.append((messages.warning, message)) | ||
| partially_update_translations(displays, is_display=True) | ||
|
|
||
| if len(hints) == len(properties): |
There was a problem hiding this comment.
Recognizing this wasn't part of your changes, but this message could be consolidated with the almost exact same one for display
'A hint row for menu {index} has an unexpected case search property "{field}". '
'Case properties must appear in the same order as they do in the bulk '
'app translation download. No translations updated for this row.'
There was a problem hiding this comment.
my response to your other comment also applies to this one!
There was a problem hiding this comment.
I'm seeing that string is already used in two places, but one says "A hint row" while the other is "A display row"
I was thinking we can do something like
msg = 'A {row_property} row for menu {index} has an unexpected case search property "{field}". '
'Case properties must appear in the same order as they do in the bulk '
'app translation download. No translations updated for this row.
and we can do msg.format('hint'...) and msg.format('display'...). But nbd, certainly not blocking.
There was a problem hiding this comment.
ah you're right I misread the part of the code this comment was attached to - made the error message reusable!
Jtang-1
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Product Description
This PR fixes a bug that was preventing case property display text under the Case Search and Claim section from being pushed to Transifex and from being uploaded back into the app.
Technical Summary
Jira Ticket
These values weren't being pushed simply their type (
case_search_displayandcase_search_hint) wasn't matching the regex. There was also an old conditional where if a bulk translations upload had any of its case property text and their corresponding hints missing, it wouldn't update any of either field, even if there was partial data. I've made this more lenient for hints because empty hints won't be pushed to Transifex and so won't be included as a row in the pulled file that you upload back into the app. The bulk application translation uploader will not be blocked by partially complete hint data.Feature Flag
Feature flags necessary to use Case Search and Claim (see here)
Safety Assurance
Safety story
Tested locally and on staging.
Minimal impact to existing data. Transifex pushing and pulling are now more inclusive, as is the bulk translations uploader. If it sees that it's missing a certain hint field, it'll skip updating it.
Rollback instructions
Labels & Review