Df/update permissions max cases #34810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
millerdev
reviewed
Jun 24, 2024
corehq/apps/domain/forms.py
Outdated
Comment on lines
1170
to
1171
| def __init__(self, domain, can_edit_eula, *args, **kwargs): | ||
| self.user = kwargs.pop('user', None) |
There was a problem hiding this comment.
nit: Newer versions of Python have syntax for keyword-only arguments.
Suggested change
| def __init__(self, domain, can_edit_eula, *args, **kwargs): | |
| self.user = kwargs.pop('user', None) | |
| def __init__(self, domain, can_edit_eula, *args, user=None, **kwargs): | |
| self.user = user |
| @@ -1266,6 +1267,13 @@ def __init__(self, domain, can_edit_eula, *args, **kwargs): | |||
| ), | |||
| ) | |||
|
|
|||
| if not self.user.is_staff: | |||
There was a problem hiding this comment.
Is it possible for self.user to be None? If yes, this will throw AttributeError. If not, the user arg in the constructor could be changed to a required keyword-only argument:
def __init__(self, domain, can_edit_eula, *args, user, **kwargs):There was a problem hiding this comment.
It is not possible for self.user to be None since the dispatch in EditInternalDomainInfoView has the login_and_domain_required decorator.
dreesefadil
force-pushed
the
df/update_permissions_max_cases
branch
from
eab75f2 to
5397f58
Compare
millerdev
reviewed
Jun 24, 2024
corehq/apps/domain/views/internal.py
Outdated
Comment on lines
100
to
101
| return DomainInternalForm(self.request.domain, can_edit_eula, self.request.user, | ||
| self.request.POST) |
There was a problem hiding this comment.
I think user still has to be passed as a keyword argument, and as is it will raise TypeError.
There was a problem hiding this comment.
Sorry about that
millerdev
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Product Description
This disables the custom max update field in the project information settings for non-developers (django users with an is_staff value of False).
Technical Summary
https://dimagi.atlassian.net/browse/SAAS-15607
Feature Flag
Safety Assurance
Safety story
I observed the local effects of this change when user.is_staff was both True and False.
Automated test coverage
QA Plan
Rollback instructions
Labels & Review