Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add formLoadTime column to report #34817

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Charl1996
Copy link
Contributor

@Charl1996 Charl1996 commented Jun 25, 2024

This PR relates to this one.

Product Description

This PR adds the form load time to the Form Completion vs. Submission report.

Technical Summary

Ticket

Feature Flag

No specific FF

Safety Assurance

Safety story

Tested locally. To be tested on staging.

Automated test coverage

No automated tests

QA Plan

QA ticket to be linked

Rollback instructions

  • This PR can be reverted after deploy with no further considerations

Labels & Review

  • Risk label is set correctly
  • The set of people pinged as reviewers is appropriate for the level of risk of the change

@Charl1996 Charl1996 added the product/all-users-all-environments Change impacts all users on all environments label Jun 25, 2024
@Charl1996 Charl1996 mentioned this pull request Jun 25, 2024
4 tasks
@Charl1996 Charl1996 requested a review from mkangia June 25, 2024 15:03
@Charl1996
Copy link
Contributor Author

Keeping in draft till this one is merged.

Copy link
Contributor

@mkangia mkangia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems safe to approve it even then.

@Charl1996
Copy link
Contributor Author

I'm going to bring this out of draft status since I don't expect any changes to this.

@Charl1996 Charl1996 marked this pull request as ready for review July 1, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product/all-users-all-environments Change impacts all users on all environments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants