-
-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ce/connect messaging #35364
Open
calellowitz
wants to merge
57
commits into
master
Choose a base branch
from
ce/connect-messaging
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Ce/connect messaging #35364
Changes from all commits
Commits
Show all changes
57 commits
Select commit
Hold shift + click to select a range
0043322
add models and rename function
calellowitz 7bc3854
add connect backend
calellowitz c609f0d
add connectid settings and urls
calellowitz e4b6deb
add connect messages to scheduling forms
calellowitz 929204d
add necessary auth changes
calellowitz 79154f0
update domain deletion code for new models
calellowitz 460c794
use updated method name
calellowitz 092dbe0
implement survey model
calellowitz f29ebfc
fix default values
calellowitz 91ce6e6
move content fields to top level of payload
calellowitz 4b992c7
use string for the key
calellowitz 36a800f
return the value
calellowitz 472609a
typo
calellowitz 1efd62e
incoming messaging processing updates
calellowitz 80e0345
handle connect content
calellowitz f327d55
add create channel views
calellowitz 6d9e562
add connect survey content
calellowitz 8421124
update models for connect message survey
calellowitz e725557
return context
calellowitz a9b2f08
correct template name
calellowitz d5935d2
use correct context name
calellowitz 7a59b8e
add imports
calellowitz ef87ae1
update view args
calellowitz 7680272
handle incorrect username
calellowitz 921d8be
add urls to sidebar
calellowitz 70bce3c
require toggle
calellowitz a3b39ff
fix f strings
calellowitz f1a02f8
fix typo in view name
calellowitz 7be46a3
Update corehq/messaging/scheduling/forms.py
calellowitz 370bab0
use message instead of payload dict
calellowitz d869378
Merge branch 'master' into ce/connect-messaging
orangejenny 63f9b29
return url list
calellowitz 5b85e3f
fix auth and pull out key generation
calellowitz 11a6e7f
create key on sending first message if not created yet
calellowitz 00fd753
add missing imports
calellowitz e810011
fix typo in form initial values
calellowitz 2c5b5fc
set message id on init
calellowitz 5de9a9f
missing import and definition
calellowitz 0231864
use domain instead of domain_scope
calellowitz 596eba4
fix function error
calellowitz 0fa683e
pr feedback and report error
calellowitz c67ac9e
update report
calellowitz 10737b7
lint
calellowitz 8dd41f1
convert to f strings
calellowitz a66ec40
move copy and lint
calellowitz c047e8e
move critical section to base class
calellowitz 75184ce
make try block narrower
calellowitz 7d66924
add success message to channel creation
calellowitz b652ddb
replace get_sms_class
calellowitz b28cdbf
update sms docs
calellowitz 867dd47
Merge branch 'master' into ce/connect-messaging
calellowitz f50e557
fix bad merge
calellowitz eccc425
squash migrations
calellowitz ae2d380
replace method with property
calellowitz aaffbaa
add new models to domain deletion and dump
calellowitz 7142730
add more models to domain deletion
calellowitz 599af78
fix bug in channel creation and improve message
calellowitz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's weird that connectid is one word. I do see that it's consistent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think of
connectid
as its own thing (its a separate repo and site than connect), using one word feels like it implies that, rather than the id for connect, but I am not wedded to it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
connectid
and "the id for connect` being two separate concepts sounds confusing, but I don't think I have enough context on the project to be certain or to make a better suggestion.