Moved UCR base template into UCR app #35500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technical Summary
I'm getting my head around the directory structure for reports/UCRs and think "base_template_new.html" isn't a good name. This is only used by UCRs, so I'm moving it into that app.
Feature Flag
UCR
Safety Assurance
Safety story
This is a straightforward change. I verified locally that both report builder (the flow that starts with "Choose your data source...") and a report builder report (displaying the actual data) load, just to verify I didn't misspell anything.
Automated test coverage
doubt it
QA Plan
no
Rollback instructions
Labels & Review