Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated geospatial reports to pull turf from NPM #35502

Merged
merged 4 commits into from
Dec 17, 2024
Merged

Updated geospatial reports to pull turf from NPM #35502

merged 4 commits into from
Dec 17, 2024

Conversation

orangejenny
Copy link
Contributor

Technical Summary

Followup for #33020

Standard practice is to get dependencies from NPM and store them in package.json. This lets us track them systematically, including getting notified of CVEs.

Feature Flag

Microplanning

Safety Assurance

Safety story

I verified locally that the "Microplanning Map" and "Case Clustering Map" both load without javascript errors. My local versions don't have data in them. If there's more testing that should be done to verify this change, let's talk.

Automated test coverage

probably not

QA Plan

Not requesting QA.

Rollback instructions

  • This PR can be reverted after deploy with no further considerations

Labels & Review

  • Risk label is set correctly
  • The set of people pinged as reviewers is appropriate for the level of risk of the change

@orangejenny orangejenny added the product/invisible Change has no end-user visible impact label Dec 10, 2024
@orangejenny orangejenny requested a review from a team as a code owner December 10, 2024 23:37
@dimagimon dimagimon added the dependencies Pull requests that update a dependency file label Dec 10, 2024
@orangejenny orangejenny requested a review from biyeun as a code owner December 10, 2024 23:40
dannyroberts
dannyroberts approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@dannyroberts dannyroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge conflict resolution looks good

@orangejenny orangejenny merged commit 92e3352 into master Dec 17, 2024
12 checks passed
@orangejenny orangejenny deleted the jls/npm-turf branch December 17, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@millerdev millerdev millerdev approved these changes

@dannyroberts dannyroberts dannyroberts approved these changes

@sravfeyn sravfeyn Awaiting requested review from sravfeyn

@mkangia mkangia Awaiting requested review from mkangia

@gherceg gherceg Awaiting requested review from gherceg

@SmittieC SmittieC Awaiting requested review from SmittieC

@biyeun biyeun Awaiting requested review from biyeun biyeun is a code owner

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file product/invisible Change has no end-user visible impact
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@orangejenny @dannyroberts @millerdev @dimagimon