[B5] Internal project pages #35536
Merged
[B5] Internal project pages #35536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s.html' as complete and un-split files."
…ileges.html' as complete and un-split files."
…n*.html' as complete and un-split files."
…main.html' as complete and un-split files."
millerdev
added
the
product/admin
orangejenny
approved these changes
Dec 18, 2024
| @@ -4,6 +4,20 @@ | |||
|
|
|||
| {% js_entry 'domain/js/bootstrap5/toggles' %} | |||
|
|
|||
| {% block stylesheets %} | |||
| <style> | |||
There was a problem hiding this comment.
Musing: I wonder if it will be worthwhile to pull these into generally available classes, named similarly to these ones. But I don't know think that's important unless/until another use case comes up. I don't know offhand of other places we use background colors like this.
I do prefer to pull page-specific styles into their own scss sheets, because it's easier to get an overview of all styles in HQ by looking across the scss files, rather than needing to search for style blocks in HTML pages.
There was a problem hiding this comment.
I will keep that in mind and pull them out if I come across other similar styles that could be generally useful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Templates migrated
Links are to the equivalent page on staging, but note that this branch has not been deployed on staging.
🐡 Review by commit.
Project Settings / Feature Flags and Privileges
Project Settings / Calculated Properties
Project Settings / Transfer Project (feature flag)
Will have vertical form layout until #35519 is merged.
Project Settings / Transfer Project (Pending)
Accept project transfer
Safety Assurance
Safety story
Only affects internal/admin views and the feature-flagged transfer project forms.
Automated test coverage
No.
QA Plan
No QA.
Rollback instructions