Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add text-break class to force breaking filenames #35559

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MartinRiese
Copy link
Contributor

@MartinRiese MartinRiese commented Dec 23, 2024

Product Description

before

2024-12-23_09-11-13

after

2024-12-23_09-10-22

Technical Summary

https://dimagi.atlassian.net/browse/USH-4219

Feature Flag

web_apps_upload_questions

Safety Assurance

Only affects styling. Tested locally

Safety story

Automated test coverage

QA Plan

No QA needed for style only changes.

Rollback instructions

  • This PR can be reverted after deploy with no further considerations

Labels & Review

  • Risk label is set correctly
  • The set of people pinged as reviewers is appropriate for the level of risk of the change

* Documentation: https://getbootstrap.com/docs/5.0/utilities/text/#word-break
* Some filename do not have natural places to break the text at. Force
  it.
* Replace some inline style with b5 classes. The left margin is not 1:1
  but replaces 7px with 0.5rem which is equivalent to 8px.
@dimagimon dimagimon added the Risk: Medium Change affects files that have been flagged as medium risk. label Dec 23, 2024
@MartinRiese MartinRiese marked this pull request as ready for review December 23, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Risk: Medium Change affects files that have been flagged as medium risk.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants