Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows 10 Touch Chrome 70, the touch feature is disabled #1579

Closed
florianduros opened this issue Nov 13, 2018 · 7 comments
Closed

Windows 10 Touch Chrome 70, the touch feature is disabled #1579

florianduros opened this issue Nov 13, 2018 · 7 comments

Comments

@florianduros
Copy link

florianduros commented Nov 13, 2018

Hello,

With chrome 70 in windows 10, the touch check in src/js/framework-bridge.js doesn't work as expected:

features.touch = 'ontouchstart' in window;

The touch verification can be done in this way:

features.touch = 'ontouchstart' in document.documentElement || navigator.maxTouchPoints > 0

It covers most of the recent browsers in touch mode

@florianduros florianduros changed the title On Windows 10 Touch chrome 70, the touch feature is disabled Windows 10 Touch Chrome 70, the touch feature is disabled Nov 13, 2018
CDrummond added a commit to CDrummond/lms-material that referenced this issue Nov 20, 2018
@theenoahmason
Copy link

Can confirm, Photoswipe not swiping on all windows 10 touch laptops, surface devices, and other windows 10 tablets in latest chrome.

@GDovis
Copy link

GDovis commented Dec 14, 2018

I have the same problem. Does not work on Chrome and Opera browsers in Windows10 on ultrabook with touchscreen. In other browsers works fine.
Tried your solution - it fixed sliding problem, but new problem appeared.
Now when I click to outside of image with touchscreen - nothing happens. If I double click - image "Zoom" function gets triggered. Before this fix clicking outside of image once made "Exit" (same as ESC button on keyboard) function.
Is it possible to fix this too? Thanks.

@theenoahmason
Copy link

theenoahmason commented Dec 14, 2018

@GDovis PhotoSwipe never closed on tap. It closes when tapping the close button, or when swiping away / pinching out.

@GDovis
Copy link

GDovis commented Dec 14, 2018

Attaching screenshot it works when you pres out of frame (picture) and it worked before this fix: http://prntscr.com/luzpa9
You cant test it here too: http://photoswipe.com/

After this fix scroll works on all browsers with touchscreen but clicking outside of frame zooms to picture instead of closing it. It acts the same as you press on actual picture (zoom happens) but outside of frame it closes by default, not zooms.

@GDovis
Copy link

GDovis commented Dec 17, 2018

So is there any normal fix to this? Other gallery plugins has it fixed by default. I'm using "dream-theme the7" theme which includes this gallery plugin so I'm stuck with this gallery. The7 theme support forwarded me here.
I also wrote letter to this gallery plugin developer and got no respond.
Is this gallery plugin gets support by the one who made it?..

@florianduros
Copy link
Author

I still have the issue with the last release 4.1.3. The touch feature is still disabled.

su-ex pushed a commit to su-ex/PhotoSwipe that referenced this issue Jan 10, 2019
@GDovis
Copy link

GDovis commented Aug 16, 2019

Greetings, bug is fixed but partly. Tested on windows 10 multi-touch Lenovo ultrabook with latest updates your demo from here: https://photoswipe.com
On Chrome and on Edge now it works.
But on Internet explorer (v11.678) touch-slide photos option does not work.

Interestingly I use your plugn trough Theme: https://the7.io/
And they gave me solution before your bug was fixed:

main.min.js:
replace
d.touch="ontouchstart"in window
with
d.touch="ontouchstart"in document.documentElement||navigator.maxTouchPoints>0

And with this fix even in Internet explorer multi-touch works.
so maybe you can update your code too so it will be fixed in IE (now its only fixed in Chrome and Edge)

EDIT: @florianduros I see this ticket is disablet, can you check it please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants