Breakpoint switch detection: revalidates images when switch occurs #50
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR the following major changes are introduced:
The data-* attributes are no longer removed. Was there any strong reason to remove them? I have an idea to still be able achieve the major goal even if the attributes are removed.
On each
validate()
it checks if the resize jumped across a breakpoint. If no breakpoints are defined, the additional code doesn't even run.Let me hear your feedback and I can fine-tune this, fix and
push -f
so that the merge is as clean as possible.Cheers @dinbror!