This repository has been archived by the owner on Apr 25, 2024. It is now read-only.
[DIR-1017] make logo changeable #526
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan Kracht <stefan.kracht@direktiv.io>
Signed-off-by: Stefan Kracht <stefan.kracht@direktiv.io>
Signed-off-by: Stefan Kracht <stefan.kracht@direktiv.io>
Signed-off-by: Stefan Kracht <stefan.kracht@direktiv.io>
Signed-off-by: Stefan Kracht <stefan.kracht@direktiv.io>
Signed-off-by: Stefan Kracht <stefan.kracht@direktiv.io>
Signed-off-by: Stefan Kracht <stefan.kracht@direktiv.io>
Signed-off-by: Stefan Kracht <stefan.kracht@direktiv.io>
Signed-off-by: Stefan Kracht <stefan.kracht@direktiv.io>
Signed-off-by: Stefan Kracht <stefan.kracht@direktiv.io>
Signed-off-by: Stefan Kracht <stefan.kracht@direktiv.io>
Signed-off-by: Stefan Kracht <stefan.kracht@direktiv.io>
Signed-off-by: Stefan Kracht <stefan.kracht@direktiv.io>
Signed-off-by: Stefan Kracht <stefan.kracht@direktiv.io>
Signed-off-by: Stefan Kracht <stefan.kracht@direktiv.io>
Signed-off-by: Stefan Kracht <stefan.kracht@direktiv.io>
Signed-off-by: Stefan Kracht <stefan.kracht@direktiv.io>
Signed-off-by: Stefan Kracht <stefan.kracht@direktiv.io>
Signed-off-by: Stefan Kracht <stefan.kracht@direktiv.io>
Signed-off-by: Stefan Kracht <stefan.kracht@direktiv.io>
Signed-off-by: Stefan Kracht <stefan.kracht@direktiv.io>
Signed-off-by: Stefan Kracht <stefan.kracht@direktiv.io>
This reverts commit 3a38377. Signed-off-by: Stefan Kracht <stefan.kracht@direktiv.io>
Signed-off-by: Stefan Kracht <stefan.kracht@direktiv.io> # Conflicts: # Dockerfile.base # Dockerfile.dev # README.md
# Conflicts: # src/pages/OnboardingPage.tsx # src/pages/namespace/Layout.tsx
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces an environment variable to allow logo customization. The design components have been updated to handle a logo in any possible size without breaking the UI.
This change requires us to provide two logo versions, one for light mode and one for dark mode. Since the Direktiv logo is a static SVG, we were able to target the dark or light mode variation via tailwind classes at runtime. However, the theming behavior of a custom logo can not be known at runtime or the logo might not even be an SVG.
This change adds application state to the Logo component, which made me introduce a new Logo component inside the
componentsNextfolder to not leak application logic into our design system.The new env variables are documented in the
.env.examplefileAdditional fixes/improvements:
yarn run previewcommand to scripts and Readme.mdupdated(already merged i a different pr)src/api/registries/schema.tsto be compatible with the latest version of the backendb0266f2b7de2d49960f60ac0753c4ec5670d1805