naive wave 1 of moving to STJ #1026
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calledude
reviewed
Oct 11, 2024
Comment on lines
+144
to
+147
| .AddJsonOptions(options => | ||
| { | ||
| options.SerializerSettings.Converters.Add(new StringEnumConverter()); | ||
| options.SerializerSettings.Converters.Add(new StringULongConverter()); | ||
| options.JsonSerializerOptions.Converters.Add(new JsonStringEnumConverter()); | ||
| options.JsonSerializerOptions.Converters.Add(new StringULongConverter()); |
There was a problem hiding this comment.
FWIW, I don't think this is needed
In the WASM rewrite I completely removed newtonsoft on the ASP.NET side of things including the converters
I assume this is a remnant from the Vue days.
There was a problem hiding this comment.
let me update the PR description to clarify the context
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this was done, probably at the end of 2023
I just pushed it for someone else if they wanted to take a look 😄
and it's also incomplete
it was mostly "so that it's not lost"
that's also in draft for that reason
I'll probably remove it at some point and delete the branch / fork and everything