Improve channel getters on events #1950
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MinnDevelopment
added
type: enhancement
status: documentation needed
Also fix some exception messages
Comment on lines
+97
to
98
| * <br>If this channel event was not received in a {@link TextChannel TextChannel}, | ||
| * this will throw an {@link java.lang.IllegalStateException}. |
There was a problem hiding this comment.
Suggested change
| * <br>If this channel event was not received in a {@link TextChannel TextChannel}, | |
| * this will throw an {@link java.lang.IllegalStateException}. |
Comment on lines
+124
to
+125
| * <br>If this event was not received from a {@link net.dv8tion.jda.api.entities.Guild Guild}, | ||
| * this will throw an {@link java.lang.IllegalStateException}. |
There was a problem hiding this comment.
Suggested change
| * <br>If this event was not received from a {@link net.dv8tion.jda.api.entities.Guild Guild}, | |
| * this will throw an {@link java.lang.IllegalStateException}. |
Comment on lines
+144
to
+153
| @Nonnull | ||
| public MessageChannel getMessageChannel() | ||
| { | ||
| if (!getChannelType().isMessage()) | ||
| throw new IllegalStateException("This event did not happen for a message channel"); | ||
| return (MessageChannel) channel; | ||
| } | ||
|
|
||
| @Nonnull | ||
| public GuildMessageChannel getGuildMessageChannel() |
|
Closing in favor of #2138 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Etiquette
Changes
Closes Issue: NaN
Description
This adds all the remaining getters for channel related events. I intentionally did not update any interaction events because that will be addressed by the rework there.