Skip to content

Commit

Permalink
Update according to PR suggestions
Browse files Browse the repository at this point in the history
* Reword sentences of deployment article for clarification & remove mention of portability
* Fix typos/grammar errors within TextChannelProperties
  • Loading branch information
Still Hsu committed Dec 23, 2018
1 parent 7f9bd3e commit 5fb6ba5
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 11 deletions.
5 changes: 2 additions & 3 deletions docs/guides/commands/post-execution.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,8 @@ about the impact in @FAQ.Commands.General.
Enter [CommandExecuted], an event that was introduced in
Discord.Net 2.0. This event is raised whenever a command is
executed regardless of its execution status. This means this
event can be used to streamline your post-execution design, and the
best thing about this event is that it is not prone
to `RunMode.Async`'s [ExecuteAsync] drawbacks.
event can be used to streamline your post-execution design,
is not prone to `RunMode.Async`'s [ExecuteAsync] drawbacks.

Thus, we can begin working on code such as:

Expand Down
10 changes: 5 additions & 5 deletions docs/guides/deployment/deployment.md
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ When redistributing the application - whether for deployment on a
remote machine or for sharing with another user - you may want to
publish the application; in other words, to create a
self-contained package without installing the dependencies
and the runtime on the target machine.
and the runtime on the target platform.

### Framework-dependent Deployment

Expand All @@ -76,7 +76,8 @@ program.

> [!TIP]
> Do not know how to run a .NET Core application with
> the `dotnet` runtime? Navigate to the folder of the program and
> the `dotnet` runtime? Navigate to the folder of the program
> (typically under `$projFolder/bin/Release`) and
> enter `dotnet program.dll` where `program.dll` is your compiled
> binaries.
Expand All @@ -89,9 +90,8 @@ machine without the `dotnet` runtime), publish with a specific
This will create a package with dependencies compiled for the target
platform, meaning that all the required dependencies will be included
with the program. This will result in **larger package size**;
however, not only is the portabilitiy greatly increased, but also the
it will include a copy of the executable that can be run
natively on the target runtime.
however, that means the copy of the runtime that can be run
natively on the target platform.

For example, the following command will create a Windows
executable (`.exe`) that is ready to be executed on any
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,15 +21,15 @@ public class TextChannelProperties : GuildChannelProperties
/// </summary>
/// <remarks>
/// Setting this value to <c>true</c> will mark the channel as NSFW (Not Safe For Work) and will prompt the
/// user about its maturity nature before they may view the channel; setting this value to <c>false</c> will
/// mark this channel as SFW (Safe For Work).
/// user about its possibly mature nature before they may view the channel; setting this value to <c>false</c> will
/// remove the NSFW indicator.
/// </remarks>
public Optional<bool> IsNsfw { get; set; }
/// <summary>
/// Gets or sets the slow-mode ratelimit in seconds for this channel.
/// </summary>
/// <remarks>
/// Setting this value to anything above zero will require each user to wait X amount of second before
/// Setting this value to anything above zero will require each user to wait X seconds before
/// sending another message; setting this value to <c>0</c> will disable slow-mode for this channel.
/// <note>
/// Users with <see cref="Discord.ChannelPermission.ManageMessages"/> or
Expand Down

0 comments on commit 5fb6ba5

Please sign in to comment.