Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Creator property to (Guild?)Emote #1213

Closed
Joe4evr opened this issue Dec 14, 2018 · 2 comments
Closed

Add Creator property to (Guild?)Emote #1213

Joe4evr opened this issue Dec 14, 2018 · 2 comments

Comments

@Joe4evr
Copy link
Contributor

Joe4evr commented Dec 14, 2018

Discord's API returns the user who created an emote as part of the emote payload. We should give users the ability to access that if possible.

Proposed addition:

public partial class GuildEmote
{
    public Optional<IUser> Creator { get; }
}

Update: Adjust to feedback.

@FiniteReality
Copy link
Member

This would probably only work on GuildEmote as Emote does not have the information required to have a Creator property, as it's mainly created using Emote.Parse("<:name:id>").

I see no problem with adding it to GuildEmote, however.

foxbot added a commit that referenced this issue Dec 20, 2018
Co-authored-by: Chris Johnston <chris@thejohnstons.net>

commit 23f5abba4822151a6ba9cb5078752b113c4b8ce6
Author: Christopher Felegy <foxbot@protonmail.com>
Date:   Thu Dec 20 17:10:21 2018 -0500

    lint: clean up some long lines

commit 4a8a809
Author: Chris Johnston <chris@thejohnstons.net>
Date:   Sat Dec 15 00:33:05 2018 -0800

    Explain why CreatorId can be null sometimes

commit 9442e4e
Author: Chris Johnston <chris@thejohnstons.net>
Date:   Fri Dec 14 23:59:01 2018 -0800

    Add the CreatorId property to GuildEmote implementation

commit e0eb94d
Author: Chris Johnston <chris@thejohnstons.net>
Date:   Fri Dec 14 23:41:54 2018 -0800

    Update the Emoji API model to add User? attribute
@foxbot
Copy link
Member

foxbot commented Dec 20, 2018

Resolved via 92bf836

@foxbot foxbot closed this as completed Dec 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants