-
-
Notifications
You must be signed in to change notification settings - Fork 736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempting to add the everyone role to a user causes 404 #780
Comments
It doesn't seem like it would be good design to just start throwing out invalid request parameters - if anything, we could add a precondition here to preemptively stop role modifications with the everyone role attached (as we do with the 14-day age limit on bulk delete) |
I could see people accidentally adding EveryoneRole when filtering through the roles collection with LINQ - I know I did several times. I think adding a check on |
* Throw when attempting to add or remove a member's EveryoneRole This resolves #780 * Removed braces
…rd-net#781) * Throw when attempting to add or remove a member's EveryoneRole This resolves discord-net#780 * Removed braces
Title.
Reproducible using
Stack trace
This will also cause issues when adding roles whose collection contains the Everyone role (i.e.
IGuildUser#AddRolesAsync()
), the method will throw and exit immediately.imo
AddRoleAsync
method should ignore the everyone role of the guild.The text was updated successfully, but these errors were encountered: