Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ChannelPermissions Modify parameter to be correct default value #1003

Merged
merged 11 commits into from
May 26, 2018
Merged

Fix ChannelPermissions Modify parameter to be correct default value #1003

merged 11 commits into from
May 26, 2018

Commits on Mar 27, 2018

  1. fix channel permissions modify parameter to use nullable boolean, cor… 

    …rect default value
    @Chris-Johnston
    Chris-Johnston committed Mar 27, 2018
    Configuration menu
    Copy the full SHA
    a1102c7 View commit details
    Browse the repository at this point in the history

  2. Add general tests for the ChannelPermissions.Modify method to test de… 

    …fault values
    @Chris-Johnston
    Chris-Johnston committed Mar 27, 2018
    Configuration menu
    Copy the full SHA
    ef56f6b View commit details
    Browse the repository at this point in the history

  3. remove unused cast in tests

    @Chris-Johnston
    Chris-Johnston committed Mar 27, 2018
    Configuration menu
    Copy the full SHA
    1bd2563 View commit details
    Browse the repository at this point in the history

  4. add guildpermission modify no param tests

    @Chris-Johnston
    Chris-Johnston committed Mar 27, 2018
    Configuration menu
    Copy the full SHA
    2aecd13 View commit details
    Browse the repository at this point in the history

  5. Add no-param modify tests for OverwritePermissions

    @Chris-Johnston
    Chris-Johnston committed Mar 27, 2018
    Configuration menu
    Copy the full SHA
    974f7df View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2018

  1. fix inconsistent parameters in GuildPermissions cstr

    @Chris-Johnston
    Chris-Johnston committed Apr 6, 2018
    Configuration menu
    Copy the full SHA
    27b1a5b View commit details
    Browse the repository at this point in the history

  2. Adjust formatting of methods and cstrs with many parameters

    @Chris-Johnston
    Chris-Johnston committed Apr 6, 2018
    Configuration menu
    Copy the full SHA
    9207782 View commit details
    Browse the repository at this point in the history

  3. remove temp file that was included. no idea what that is

    @Chris-Johnston
    Chris-Johnston committed Apr 6, 2018
    Configuration menu
    Copy the full SHA
    bc9f71c View commit details
    Browse the repository at this point in the history

Commits on May 25, 2018

  1. Merge branch 'dev' into fix-use-external-emojis

    @Chris-Johnston
    Chris-Johnston authored May 25, 2018
    Configuration menu
    Copy the full SHA
    ca5eb56 View commit details
    Browse the repository at this point in the history

  2. Fix System dependency 

    I should really stop fixing merge conflicts in the github website.
    @Chris-Johnston
    Chris-Johnston committed May 25, 2018
    Configuration menu
    Copy the full SHA
    6126ca8 View commit details
    Browse the repository at this point in the history

Commits on May 26, 2018

  1. Merge branch 'dev' into fix-use-external-emojis

    @foxbot
    foxbot authored May 26, 2018
    Configuration menu
    Copy the full SHA
    e07d630 View commit details
    Browse the repository at this point in the history