Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: consolidate all results into CommandExecuted #1164

Merged
merged 2 commits into from
Oct 19, 2018
Merged

feature: consolidate all results into CommandExecuted #1164

merged 2 commits into from
Oct 19, 2018

Commits on Sep 30, 2018

  1. feature: consolidate all results into CommandExecuted 

    This resolves #694.

This is a breaking change!
- changes the signature of CommandExecuted from (CommandInfo, ...) to
(Optional<CommandInfo>, ...), since we are now including Search result
failures in the event (and a command isn't accessible yet).
    @foxbot
    foxbot committed Sep 30, 2018
    Configuration menu
    Copy the full SHA
    73d9abb View commit details
    Browse the repository at this point in the history

  2. lint: remove unfinished thoughts

    @foxbot
    foxbot committed Sep 30, 2018
    Configuration menu
    Copy the full SHA
    7c7e30c View commit details
    Browse the repository at this point in the history