Fix #1216, Add support for spoiler formatting & attachments #1255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chris-Johnston
changed the title
Joe4evr
reviewed
Feb 1, 2019
| /// <summary> | ||
| /// The prefix applied to files to indicate that it is a spoiler. | ||
| /// </summary> | ||
| public const string SpoilerPrefix = "SPOILER_"; |
There was a problem hiding this comment.
👀? We're not building with preview compiler versions, are we?
How does this not produce a CI failure?
There was a problem hiding this comment.
Nope, this was just my mistake. I didn't build before committing. Also, it seems that CI hasn't been working since we moved to the org.
There was a problem hiding this comment.
Yeah, we need to get it moved over from Volt's personal repo. cc @RogueException
|
Should also be added to |
adds the isSpoiler field to uploading files with a webhook, which will only insert "SPOILER_" to the start of the filename. This does not include other fields in the payload, as this is not in the documentation, and was not observed like in the regular client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1216
Implements support for formatting text as spoilers, and spoiler attachments.
Formatclass.|to the list of characters to escape, since this is used for formatting spoilers.isSpoileroptional parameter toSendFileAsync.UploadFileParams. When this is set to true, the file name will be prefixed with the text"SPOILER_". Will also send thehasSpoilervalue in the upload request body.SPOILER_, and not that thehasSpoilerproperty is supplied.IAttachmentwhich checks if an attachment is a spoiler. Spoilers attachments can be of any type, not just images.