Fix false invalidation when decoding token User Ids #1278
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue when trying to validate older bot tokens. The first segment is a base64-encoded string that contains a ulong. The format that discord provides will not contain any padding, while
Convert.FromBase64String
will throw aFormatException
when trying to decode from a string that requires it (string length is not a multiple of 4).This PR:
Original conversation can be found here.