Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialize ImmutableArray fields #1292

Merged
merged 1 commit into from
Mar 26, 2019
Merged

Initialize ImmutableArray fields #1292

merged 1 commit into from
Mar 26, 2019

Conversation

Joe4evr
Copy link
Contributor

@Joe4evr Joe4evr commented Mar 25, 2019

Fixes #1291.

I opted to use Create<T>() to stay consistent, but I'd still say calling ImmutableArray<T>.Empty directly would keep things more efficient (wouldn't do more than a ldsfld whereas Create<T>() would do a call+ldsfld+ret if inlining fails).

@foxbot foxbot merged commit b2ebc03 into discord-net:dev Mar 26, 2019
@Joe4evr Joe4evr deleted the init-immutable-arrays branch March 27, 2019 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
priority: bug project: core version: patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Joe4evr @foxbot