[Bugfix] fixed an NRE when event was changed from in channel to external or vice versa #2483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rekkonnect
suggested changes
Oct 19, 2022
src/Discord.Net.Rest/Entities/AuditLogs/DataTypes/ScheduledEventInfo.cs
Outdated
Show resolved
Hide resolved
src/Discord.Net.Rest/Entities/AuditLogs/DataTypes/ScheduledEventInfo.cs
Outdated
Show resolved
Hide resolved
src/Discord.Net.Rest/Entities/AuditLogs/DataTypes/ScheduledEventUpdateAuditLogData.cs
Show resolved
Hide resolved
src/Discord.Net.Rest/Entities/AuditLogs/DataTypes/ScheduledEventUpdateAuditLogData.cs
Outdated
Show resolved
Hide resolved
src/Discord.Net.Rest/Entities/AuditLogs/DataTypes/ScheduledEventUpdateAuditLogData.cs
Show resolved
Hide resolved
src/Discord.Net.Rest/Entities/AuditLogs/DataTypes/ScheduledEventUpdateAuditLogData.cs
Outdated
Show resolved
Hide resolved
|
Hey @Rekkonnect , could you have another look at this? |
|
LGTM nice edits |
csmir
approved these changes
Jan 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a nre from my earlier contribution that occurred when an scheduled-event update audit log entry contained a change that changed the event type from internal to exernal. I forgot to handle the fact that channel ids and location names can actually have a null value (only one of them can actually have a non null value at the same time). Also there now is a way to differentiate between those values not having changed (the property is null in that case) and the value changing from/to a null value (the optional will be unset / the id will be 0).